Re: Patch for pgAdmin4 package on Mac OS X

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Sandeep Thakkar <sandeep(dot)thakkar(at)enterprisedb(dot)com>
Cc: Paresh More <paresh(dot)more(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Hamid Quddus <hamid(dot)quddus(at)enterprisedb(dot)com>
Subject: Re: Patch for pgAdmin4 package on Mac OS X
Date: 2016-05-24 15:55:56
Message-ID: CA+OCxoxFap1FVqsrcHG4QU2zDUu6v_5WkyYO3xYyS2yufbq5AA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

Attached is an updated patch in which I made some minor changes, most
significantly, to stop the build script from over-writing my
configuration file (again)!

There are a couple of important issues to be resolved:

1) It doesn't work. When testing on Karen's machine (which is new, and
doesn't have any dev environment etc), it errors out because it looks
like it cannot find the virtual environment.

2) It's *huge* - like 650MB!! I believe we're bundling much of QT
which isn't required. Please only copy what is needed.

Thanks!

On Mon, May 23, 2016 at 7:22 AM, Sandeep Thakkar
<sandeep(dot)thakkar(at)enterprisedb(dot)com> wrote:
> Hi Dave
>
> I have fixed this issue. Instead of getting path from otool, script now uses
> QTDIR variable to copy the framework directory. Please find the updated
> patch attached.
>
> Thanks.
>
> On Thu, May 19, 2016 at 7:39 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> On Thu, May 19, 2016 at 10:05 AM, Sandeep Thakkar
>> <sandeep(dot)thakkar(at)enterprisedb(dot)com> wrote:
>> > Hmm.. looks like some difference in the QT installation.
>> >
>> > Can you please provide me the otool -L output for pgAdmin4 from
>> > /mac-build/pgAdmin4.app/Contents/MacOS/pgAdmin4
>>
>> (pgadmin4)snake:pgadmin4 dpage$ otool -L
>> mac-build/pgAdmin4.app/Contents/MacOS/pgAdmin4
>> mac-build/pgAdmin4.app/Contents/MacOS/pgAdmin4:
>> /System/Library/Frameworks/Python.framework/Versions/2.7/Python
>> (compatibility version 2.7.0, current version 2.7.10)
>> /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current
>> version 1226.10.1)
>>
>> /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
>> (compatibility version 150.0.0, current version 1258.1.0)
>> @rpath/QtWebKitWidgets.framework/Versions/5/QtWebKitWidgets
>> (compatibility version 5.5.0, current version 5.5.1)
>> @rpath/QtWidgets.framework/Versions/5/QtWidgets (compatibility version
>> 5.5.0, current version 5.5.1)
>> @rpath/QtGui.framework/Versions/5/QtGui (compatibility version 5.5.0,
>> current version 5.5.1)
>> @rpath/QtCore.framework/Versions/5/QtCore (compatibility version
>> 5.5.0, current version 5.5.1)
>>
>> /System/Library/Frameworks/DiskArbitration.framework/Versions/A/DiskArbitration
>> (compatibility version 1.0.0, current version 1.0.0)
>> /System/Library/Frameworks/IOKit.framework/Versions/A/IOKit
>> (compatibility version 1.0.0, current version 275.0.0)
>> @rpath/QtWebKit.framework/Versions/5/QtWebKit (compatibility version
>> 5.5.0, current version 5.5.1)
>> @rpath/QtNetwork.framework/Versions/5/QtNetwork (compatibility version
>> 5.5.0, current version 5.5.1)
>> /System/Library/Frameworks/OpenGL.framework/Versions/A/OpenGL
>> (compatibility version 1.0.0, current version 1.0.0)
>> /System/Library/Frameworks/AGL.framework/Versions/A/AGL (compatibility
>> version 1.0.0, current version 1.0.0)
>> /usr/lib/libstdc++.6.dylib (compatibility version 7.0.0, current
>> version 104.1.0)
>>
>> >
>> > and also the tree for $QTDIR/lib
>>
>> Attached.
>>
>> Also, my config database now seems to be trashed since I ran "make
>> appbundle" :-(
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>
>
>
> --
> Sandeep Thakkar
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
pgadmin-mac-appbundle-dave.diff text/plain 20.9 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-05-24 16:02:11 Re: Patch for pgAdmin4 docs
Previous Message Susan Douglas 2016-05-24 15:21:03 Patch for pgAdmin4 docs