Re: [pgAdmin4] [PATCH] History Tab rewrite in React

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: Shruti B Iyer <siyer(at)pivotal(dot)io>, Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>, Joao Pedro De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>, Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4] [PATCH] History Tab rewrite in React
Date: 2017-06-13 10:26:53
Message-ID: CA+OCxoxBYQLPvEWWYHitgieR=o26qtAbLAtcVmD4Uoom79PNAQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi
<ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> On Tue, Jun 13, 2017 at 2:47 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> And then I find a problem. Sigh.
>>
>> When running in the desktop runtime, under QtWekKit (the forked,
>> updated version that is by far the best of the browser engines we've
>> used), we get the attached error at startup. I don't see this under
>> QtWebEngine, though as we've already found, that's not usable for
>> other reasons.
>>
>> Is this fixable?
>
> As per 'http://qtwebkit.blogspot.in/2016/08/qtwebkit-im-back.html':
> "
> WebKit engine itself has not been updated since Qt 5.2 release. That's why
> it didn't support recent changes in Web standards that happened after 2013,
> including: new JavaScript language standard ES2015 (also known as ES6), as
> well as improvements in DOM API and CSS.
> ...
> "
>
> Could this be a reason?

For the old webkit, certainly, but if you read further down, the
version we're using has been updated and does now claim to support
most of ES2015.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-06-13 10:27:17 Re: pgAdmin 4 commit: Required mock package for python < 3.3.
Previous Message pgAdmin 4 Jenkins 2017-06-13 10:25:30 Build failed in Jenkins: pgadmin4-master-python33 #168