Re: pgAdmin 4 commit: Required mock package for python < 3.3.

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgAdmin 4 commit: Required mock package for python < 3.3.
Date: 2017-06-13 10:27:17
Message-ID: CA+OCxow+mxMif-Nusa4Tbmnqx_5_9bJq-3uZH_X0XP=y_GZCww@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Tue, Jun 13, 2017 at 11:25 AM, Ashesh Vashi <
ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:

> On Tue, Jun 13, 2017 at 3:52 PM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Oops.
>> let me revert it back.
>>
> 'web/regressions/requirements.txt' needs to change as it is not require
> for Python >= 3.3.
> Will do the change.
>

OK, thanks.

>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi>
>>
>> On Tue, Jun 13, 2017 at 3:50 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Is mock required at runtime, or just for tests? It's already in
>>> web/regressions/requirements.txt
>>>
>>> On Tue, Jun 13, 2017 at 11:13 AM, Ashesh Vashi
>>> <ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>> > Required mock package for python < 3.3.
>>> > It was required for the commit:
>>> > 1208206bc0eca2d135469258e8a209b983e668be
>>> >
>>> > Also, do not fetch the scenario-name, when it is not avaiable (but -
>>> use
>>> > default vaule as the stringified test-case itself).
>>> >
>>> > Branch
>>> > ------
>>> > master
>>> >
>>> > Details
>>> > -------
>>> > https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>>> f;h=903389d7b76046141c92a720e9e515cc4bb46274
>>> >
>>> > Modified Files
>>> > --------------
>>> > requirements.txt | 3 ++-
>>> > web/regression/runtests.py | 8 +++++---
>>> > 2 files changed, 7 insertions(+), 4 deletions(-)
>>> >
>>> >
>>> > --
>>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>>> > To make changes to your subscription:
>>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2017-06-13 10:28:04 pgAdmin 4 commit: Package 'mock' is required for testing, and for Pytho
Previous Message Dave Page 2017-06-13 10:26:53 Re: [pgAdmin4] [PATCH] History Tab rewrite in React