Re: [pgAdmin][RM4139] Drag and drop object names in Query Editor from Browser Tree

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM4139] Drag and drop object names in Query Editor from Browser Tree
Date: 2019-06-26 11:21:29
Message-ID: CA+OCxowrfff5pU-sKTpk8G4oDpxpYRSmJ-mZbrhWWTYPB7fubQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Wed, Jun 26, 2019 at 2:24 AM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Attached is the patch to allow tree nodes to be dragged and dropped in
> query editor wherever you take the drop cursor. The drop text will be fully
> qualified and double quoted if required.
> For functions/procedures it will drop the the label stripping away the
> parameter names, with empty pair of round brackets. It will also set the
> focus cursor inside the brackets if there were params otherwiser to the end
> of text.
> For adding a node type, you need to register it in browser.js along with a
> callback function which will return drop text along with cursor positioning
> and selection. Currently, I have registered for "table partition type
> sequence package view mview foreign_table edbvar schema column edbfunc
> function edbproc procedure".
>
> Please note, the drag design customisation is not supported in IE.
>

I think for functions/procedures, we should include placeholders for the
parameters, so the user has a hint about what they need to fill in to
complete the call.

Also; shouldn't there be a doc update?

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Aditya Toshniwal 2019-06-26 11:28:13 Re: [pgAdmin][RM4139] Drag and drop object names in Query Editor from Browser Tree
Previous Message Dave Page 2019-06-26 11:01:40 Re: [GSoC][Patch] Automatic Mode Detection V1