Re: PATCH: Table header size

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Chethana Kumar <chethana(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Subject: Re: PATCH: Table header size
Date: 2019-02-08 09:25:53
Message-ID: CA+OCxowd0k8SraJBDRPGycmYOxhiHz418PUSHLyVtkhG5ErECA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

Can we adjust the top/bottom padding, but leave the left/right? By
modifying the left/right padding, we cause the data to become offset with
the header.

Otherwise I'm cool with the change.

On Fri, Feb 8, 2019 at 6:40 AM Chethana Kumar <
chethana(dot)kumar(at)enterprisedb(dot)com> wrote:

> Hi Dave/Team,
>
> Just explain it -
>
> *Change - *Increased the padding for '*th*' (table header)
>
> *Reason - *The table header is *not getting highlighted enough* thus the *sense
> of hierarchy and visual difference between 'th' and 'td' is not strong
> enough*
>
> *Case study -*
> If you see the existing version of table everything looks flat in terms of
> hierarchy due to 'white background' for both *'th'* and *'td' *except the
> header texts are in bold.
> I would recommend you to see it in the actual application for better
> clarity of the issue.
>
> *Conclusion -*
> Padding does that required *differentiation part* in order to
> highlight/achieve the hierarchy.
>
> Attaching the reference design too and going further I am aiming to reach
> this level of look and feel with our application.
> I really feel that "a good amount of breathing space sets the user's mind
> calm and focused towards reading the data" :)
>
> [image: current_rev_2x.png]
>
> ---
> Chethana kumar
>
>
> On Fri, Feb 8, 2019 at 10:34 AM Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave/Team,
>>
>> As my offline conversation with Chethana, we need better look 'n' feel
>> for the table header row.
>> And - as per his proposal I've modified the table header row to look
>> different from rest of the rows.
>>
>> Please find the attached patch for the same.
>>
>> Let me share the screen shot for the now, and proposed change.
>> Now:
>> [image: Screen Shot 2019-02-08 at 10.31.35 AM.png]
>>
>> Proposed:
>> [image: Screen Shot 2019-02-08 at 10.29.20 AM.png]
>>
>> Please let me know your thoughts.
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi>
>>
>
>
> --
> Chethana Kumar
> Principal UI/UX Designer
> EnterpriseDB Corporation
>
>
> The Postgres Database Company
>
> P: +91 86981 57146
> www.enterprisedb.com
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2019-02-08 12:56:07 Re: [pgAdmin4[RM#3948] Fix backform note control style
Previous Message Chethana Kumar 2019-02-08 06:39:53 Re: PATCH: Table header size