From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Dinesh Kumar <dinesh(dot)kumar(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Subject: | Re: pgAdmin Event Trigger Compatibility |
Date: | 2013-07-10 14:19:08 |
Message-ID: | CA+OCxow_8GUgRD78Qx6W5iAPOg-aRgL=Zg2vmAqJ31u0B6y4yA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
On Wed, Jul 10, 2013 at 10:56 AM, Dinesh Kumar <
dinesh(dot)kumar(at)enterprisedb(dot)com> wrote:
> H
> i Dave,
>
>
>
> OK, it builds fine on Mac for me now. Some initial feedback:
>>>
>>> - Instead of "DDL_COMMAND_START", we should use "DDL COMMAND START". The
>>> same applies to similar cases.
>>>
>>> Fixed it.
>
>
>> - Can we combine the Enable and Enable Status options into one set of
>>> radio buttons, e.g. Enabled (which should be the default), Replica, Always
>>> and Disabled?
>>>
>>> Yes, we can change this enable check box as a radio button. But,
> "REPLICA/ALWAYS" are two enable's properties. Hence, We have implemented
> this in the proposed way. Kindly share your opinion on this.
>
So: "Enabled Replica ( ) Enabled Always ( ) Disabled ( )" ?
>
>
>> - Please fix the sizing of the box around the aforementioned radio
>>> buttons. See the screen shots for an example of what I mean. It should
>>> match the "Fires" box on dlgTrigger.
>>>
>>>
>> Fixed it.
>
> Please find the new patch which fixes the above issues, except including
> the "Enable" check box in radio group.
>
> Thanks in advance.
>
>
> Dinesh
>
> --
> *Dinesh Kumar*
> Software Engineer
>
> Ph: +918087463317
> Skype ID: dinesh.kumar432
> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
> *
> Follow us on Twitter*
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community> and
> more <http://www.enterprisedb.com/resources-community>
>
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dinesh Kumar | 2013-07-10 16:16:20 | Re: pgAdmin Event Trigger Compatibility |
Previous Message | Dinesh Kumar | 2013-07-10 09:56:20 | Re: pgAdmin Event Trigger Compatibility |