From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> |
Cc: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, Florian Klaar <flo(dot)klaar(at)gmx(dot)de>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Patch: Auto-generate search_path statement for selected schema in query editor |
Date: | 2013-03-19 17:35:53 |
Message-ID: | CA+OCxowZx1sfcXhv5TQjFbpHfXDPgPvcne1mbhdf=oQqPr2t-w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
On Mon, Mar 18, 2013 at 1:09 PM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>wrote:
> Hi,
>
> We have checked the bug and below is our finding.
>
> As we are getting the pane information from the manager and pane could not
> be found in the manager so at that time wxAuiPaneInfo structure is not
> valid and when we call Update() then it was crashing. So before calling to
> Update() we put check for validating the wxAuxPaneInfo structure as below.
>
> wxAuiPaneInfo outputPaneInfo =
> manager.GetPane(wxT("outputPane")).Show(false);
>
> wxAuiPaneInfo scratchPad = manager.GetPane(wxT("scratchPad")).Show(false);
>
> viewMenu->Enable(MNU_OUTPUTPANE, false);
>
> viewMenu->Enable(MNU_SCRATCHPAD, false);
>
> *if (outputPaneInfo.IsOk() == true && scratchPad.IsOk() == true)*
>
> manager.Update();
>
>
> Please find the patch along with this email and let me know.
>
It still crashes for me I'm afraid. Testing on Windows, debug build, VC++
2010.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Guillaume Lelarge | 2013-03-24 16:19:38 | pgAdmin III commit: Add tab option in the Import dialog |
Previous Message | Neel Patel | 2013-03-18 13:09:00 | Re: Patch: Auto-generate search_path statement for selected schema in query editor |