Re: [pgAdmin4][Patch]: RM#1462- AJAX request do not get fired second time

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM#1462- AJAX request do not get fired second time
Date: 2016-07-18 08:50:57
Message-ID: CA+OCxowTD3oWyjvAmUxahF9-aneWD67oL54LnwxOgwNVYrvLeA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Mon, Jul 18, 2016 at 8:34 AM, Surinder Kumar
<surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi
>
> Please find attached patch for the fix:
> Issue:
> This issue is regression of one of the flickering issue of RM#1242.
> "Aside from displaying/hiding the spinner, panes should have their content
> refreshed until and unless the new data differs from the previous, to reduce
> flicker"
>
> Solution:
> Along with caching the node node, we should also keep track of the previous
> node clicked.
> Fetch new data iff previous node and current node clicked differs.

This doesn't fix the issue for me. My test case:

1) Select the SQL tab
2) Click a schema, and the SQL is displayed.
3) Click Schemas, and "-- No SQL could be generated for the selected
object." is displayed.
4) Click the same schema as in step 2 again, and "-- No SQL could be
generated for the selected object." remains displayed.

Note that clicking any other schema in step 4 works fine.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Harshal Dhumal 2016-07-18 09:32:12 Re: Regarding issue 1241
Previous Message Dave Page 2016-07-18 08:42:23 Re: PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4)