Re: PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4)

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4)
Date: 2016-07-18 08:42:23
Message-ID: CA+OCxow+G61mxYKhCSQxyf92ituN5fANbWwCxD8inTDdjF3_-A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks - applied.

On Mon, Jul 18, 2016 at 7:34 AM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> Please find patch to fix the issue for interval type casting.
>
>
> Regards,
> Murtuza
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, Jul 15, 2016 at 4:31 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> Hi
>>
>> On Thu, Jul 14, 2016 at 7:00 AM, Murtuza Zabuawala
>> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>> > Hi,
>> >
>> > PFA patch to fix the issue in timestamp datatype(s) displaying with time
>> > as
>> > 00:00
>> > (RM#1437)
>> >
>> > The issue was with backgrid datetime cell which do not fully support
>> > ISO-8601 datetime format.
>>
>> Thanks - this worked, except for the 'interval' type, I've committed
>> the patch without that change; please submit another fixing that
>> remaining issue.
>>
>> e.g. select '1 month'::interval
>>
>> displays: 00:00:00
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-07-18 08:50:57 Re: [pgAdmin4][Patch]: RM#1462- AJAX request do not get fired second time
Previous Message Dave Page 2016-07-18 08:40:46 pgAdmin 4 commit: Properly support the interval type. Fixes #1437