Re: Naming conventions for column names

From: Sachin Kotwal <kotsachin(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-general(at)postgresql(dot)org
Subject: Re: Naming conventions for column names
Date: 2017-11-07 05:30:28
Message-ID: CA+N_YAdZViVGidMHh9SASnKMuJ3eHbw1RrXFsHPPydkE9Q+0zw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

Hi,

It seems people worrying about failure of client side code after changes in
column names.

Melvin also mention that just change in one column was broken many things.

>
> > My intension is to improve naming conventions and increase naming string
> > where naming conventions are correct but make shorten.
>
>
Sure. It make sense.
Definitely we can do this. Specially patch reviewers and committers need to
take care of this. (I am not ordering to anyone here, just putting my
thoughts)

> I think the proper amount of effort to rename existing system catalog
> columns is zero.
>
> Can you clarify how efforts will be zero. Is there any script in place or
automatic way of doing this?

> Also, I think it's pretty difficult to change column names on views that
> have already been released. The compatibility break for existing tools
> is just too large.
>
>
It is correct. But then I think we can do below things:

1. Instead of pushing all changes at once , we can group them and push them
slowly in each major version release.
2. We need to decide weather we really need those changes in old versions?
3. Notify or highlight these changes in release notes because this can
break some existing tools and user code.
4. As Alvaro suggested, when developer working on any major code change, He
should give proper naming conventions to system catalog/view column names
in that area.

If It is impossible or not required to do this, then we can stop discussion
with 4th point made by Alvaro as conclusion of this discussion.

Please committers give their final view on this.

--

Thanks and Regards,
Sachin Kotwal

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Krithika Venkatesh 2017-11-07 06:38:22 Incremental refresh - Materialized view
Previous Message Zarko Aleksic 2017-11-06 22:52:47 Re: the database system is shutting down - terminating walsender process due to replication timeout