| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | jian(dot)universality(at)gmail(dot)com, tomas(dot)vondra(at)enterprisedb(dot)com, upadhyaya(dot)himanshu(at)gmail(dot)com, alvherre(at)alvh(dot)no-ip(dot)org, er(at)xs4all(dot)nl, andres(at)anarazel(dot)de, andrew(at)dunslane(dot)net, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: remaining sql/json patches |
| Date: | 2024-03-22 02:44:08 |
| Message-ID: | CA+HiwqHsOyvvjGCLsEQ50+S76-XdCXbk7MGjy2gr3eDpaG9-UA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Horiguchi-san,
On Fri, Mar 22, 2024 at 9:51 AM Kyotaro Horiguchi
<horikyota(dot)ntt(at)gmail(dot)com> wrote:
> At Wed, 20 Mar 2024 21:53:52 +0900, Amit Langote <amitlangote09(at)gmail(dot)com> wrote in
> > I'll push 0001 tomorrow.
>
> This patch (v44-0001-Add-SQL-JSON-query-functions.patch) introduced the following new erro message:
>
> + errmsg("can only specify constant, non-aggregate"
> + " function, or operator expression for"
> + " DEFAULT"),
>
> I believe that our convention here is to write an error message in a
> single string literal, not split into multiple parts, for better
> grep'ability.
Thanks for the heads up.
My bad, will push a fix shortly.
--
Thanks, Amit Langote
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Euler Taveira | 2024-03-22 03:31:34 | Re: speed up a logical replica setup |
| Previous Message | Tom Lane | 2024-03-22 02:07:19 | Re: Slow GRANT ROLE on PostgreSQL 16 with thousands of ROLEs |