Re: remaining sql/json patches

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: amitlangote09(at)gmail(dot)com
Cc: jian(dot)universality(at)gmail(dot)com, tomas(dot)vondra(at)enterprisedb(dot)com, upadhyaya(dot)himanshu(at)gmail(dot)com, alvherre(at)alvh(dot)no-ip(dot)org, er(at)xs4all(dot)nl, andres(at)anarazel(dot)de, andrew(at)dunslane(dot)net, pgsql-hackers(at)postgresql(dot)org
Subject: Re: remaining sql/json patches
Date: 2024-03-22 00:51:49
Message-ID: 20240322.095149.895185546948714852.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Wed, 20 Mar 2024 21:53:52 +0900, Amit Langote <amitlangote09(at)gmail(dot)com> wrote in
> I'll push 0001 tomorrow.

This patch (v44-0001-Add-SQL-JSON-query-functions.patch) introduced the following new erro message:

+ errmsg("can only specify constant, non-aggregate"
+ " function, or operator expression for"
+ " DEFAULT"),

I believe that our convention here is to write an error message in a
single string literal, not split into multiple parts, for better
grep'ability.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2024-03-22 00:59:54 Re: Slow GRANT ROLE on PostgreSQL 16 with thousands of ROLEs
Previous Message Nathan Bossart 2024-03-22 00:51:39 Re: Slow GRANT ROLE on PostgreSQL 16 with thousands of ROLEs