Re: json_query conditional wrapper bug

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Andreas Ulbrich <andreas(dot)ulbrich(at)matheversum(dot)de>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: json_query conditional wrapper bug
Date: 2024-09-13 07:13:05
Message-ID: CA+HiwqHN87fCiOyEJga1X_OTLE=FjUvi3ueFoSKaoqAi+CdG4w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 12, 2024 at 8:12 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
>
> Hi Andreas,
>
> On Thu, Sep 12, 2024 at 7:08 PM Andreas Ulbrich
> <andreas(dot)ulbrich(at)matheversum(dot)de> wrote:
> >
> > Salvete!
> >
> >
> > Sorry for my out of the rules replay, but I'm not at home, and also I can't verify and check your patch.
> >
> > But I think you have missed the docu in your fix:
> >
> > Must the example there not also be changed:
> >
> > From
> >
> > JSON_QUERY(jsonb '[1,[2,3],null]', 'lax $[*][$off]' PASSING 1 AS off WITH CONDITIONAL WRAPPER) → [3]
> >
> > to
> >
> > JSON_QUERY(jsonb '[1,[2,3],null]', 'lax $[*][$off]' PASSING 1 AS off WITH CONDITIONAL WRAPPER) → 3
>
> You're right, good catch.
>
> I had checked whether the documentation text needed fixing, but failed
> to notice that an example
> is using CONDITIONAL. Will fix, thanks for the report.

I have pushed the fix. Thanks Andreas for the report.

--
Thanks, Amit Langote

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo Nagata 2024-09-13 07:18:01 Re: Extend ALTER DEFAULT PRIVILEGES for large objects
Previous Message Yugo Nagata 2024-09-13 06:56:11 Re: Add has_large_object_privilege function