Re: Add has_large_object_privilege function

From: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>
Subject: Re: Add has_large_object_privilege function
Date: 2024-09-13 06:56:11
Message-ID: 20240913155611.7b952576cea9248ec5e55a45@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 12 Sep 2024 19:51:33 +0900
Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> wrote:

> On Thu, 12 Sep 2024 19:07:22 +0900
> Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>
> >
> >
> > On 2024/09/10 17:45, Yugo NAGATA wrote:
> > > On Mon, 9 Sep 2024 22:59:34 +0900
> > > Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
> > >
> > >>
> > >>
> > >> On 2024/07/02 16:34, Yugo NAGATA wrote:
> > >>> So, I would like to propose to add
> > >>> has_large_object_function for checking if a user has the privilege on a large
> > >>> object.
> > >>
> > >> +1
> > >
> > > Thank you for your looking into this!
> > > I've attached a updated patch.
> >
> > Thanks for updating the patches! LGTM, except for a couple of minor things:
> >
> > +okui chiba * has_largeobject_privilege_id
> >
> > "okui chiba" seems to be a garbage text accidentally added.
> >
> > + * role by Oid, large object by id, and privileges as AclMode.
> >
> > "Oid" seems better than "id" in "large object by id".
>
> Thank you for pointing out it.
> I've fixed them and attached the updated patch, v3.

I confirmed the patches are committed in the master branch.
Thank you!

I've updated the commitfest status to "committed".

Regards,
Yugo Nagata

--
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2024-09-13 07:13:05 Re: json_query conditional wrapper bug
Previous Message Amit Kapila 2024-09-13 06:16:27 Re: Disallow altering invalidated replication slots