| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Junwang Zhao <zhjwpku(at)gmail(dot)com> |
| Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, Tomas Vondra <tomas(at)vondra(dot)me>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Daniel Gustafsson <daniel(at)yesql(dot)se>, David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Thom Brown <thom(at)linux(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: generic plans and "initial" pruning |
| Date: | 2025-02-17 07:15:33 |
| Message-ID: | CA+HiwqGaR1jszN7=0sc8A-eHretkK7Jf9trDJE5FWT9H957zNw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Junwang,
On Sun, Feb 16, 2025 at 1:37 PM Junwang Zhao <zhjwpku(at)gmail(dot)com> wrote:
> On Sat, Feb 15, 2025 at 3:51 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> > Thanks! It looks like I missed updating the MERGE-related lists in ModifyTable.
> >
> > I've attached a fix with a test added based on your example. I plan to
> > push this on Monday.
> >
>
> I applied the patch and the problem solved,
Thanks for checking.
> I have a small question that
> should the following line
>
> ```
> if (node->mergeActionLists == NIL)
> ```
>
> be changed to
>
> ```
> if (mtstate->mt_mergeActionLists == NIL)
> ```
>
> ISTM that if we have pruned all the merge actions, there is no harm we
> omit setting mtstate->mt_merge_subcommands to 0.
Yeah, that seems harmless, so done.
I have pushed the fix now.
--
Thanks, Amit Langote
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-02-17 07:23:56 | Re: Proposal to CREATE FOREIGN TABLE LIKE |
| Previous Message | Nazir Bilal Yavuz | 2025-02-17 07:08:43 | Re: per backend WAL statistics |