Re: enable/disable broken for statement triggers on partitioned tables

On Thu, Aug 4, 2022 at 9:56 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> Another point for backpatch: EnableDisableTrigger() changes API, which
> is potentially not good. In backbranches I'll keep the function
> unchanged and add another function with the added argument,
> EnableDisableTriggerNew().

+1

> So extensions that want to be compatible with both old and current
> versions (assuming any users of that function exist out of core; I
> didn't find any) could do something like
>
> #if PG_VERSION_NUM <= 160000
> EnableDisableTriggerNew( all args )
> #else
> EnableDisableTrigger( all args )
> #endif
>
> and otherwise they're compatible as compiled today.
>
> Since there are no known users of this interface, it doesn't seem to
> warrant any more convenient treatment.

Makes sense.

--
Thanks, Amit Langote
EDB: http://www.enterprisedb.com