| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com> |
| Subject: | Re: enable/disable broken for statement triggers on partitioned tables |
| Date: | 2022-08-04 12:56:45 |
| Message-ID: | 20220804125645.ujcik53evyiuiywy@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Another point for backpatch: EnableDisableTrigger() changes API, which
is potentially not good. In backbranches I'll keep the function
unchanged and add another function with the added argument,
EnableDisableTriggerNew().
So extensions that want to be compatible with both old and current
versions (assuming any users of that function exist out of core; I
didn't find any) could do something like
#if PG_VERSION_NUM <= 160000
EnableDisableTriggerNew( all args )
#else
EnableDisableTrigger( all args )
#endif
and otherwise they're compatible as compiled today.
Since there are no known users of this interface, it doesn't seem to
warrant any more convenient treatment.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Those who use electric razors are infidels destined to burn in hell while
we drink from rivers of beer, download free vids and mingle with naked
well shaved babes." (http://slashdot.org/comments.pl?sid=44793&cid=4647152)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2022-08-04 13:00:53 | Re: Handle infinite recursion in logical replication setup |
| Previous Message | Simon Riggs | 2022-08-04 12:11:25 | Re: Smoothing the subtrans performance catastrophe |