| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: ALTER TABLE .. DETACH PARTITION CONCURRENTLY |
| Date: | 2021-04-27 07:34:30 |
| Message-ID: | CA+HiwqFVVs8wcdPV0fVQXd7+-uhXzTTJLTF4nC_L_avL0+NcZA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for the updated patch. I've been reading it, but I noticed a
bug in 8aba9322511f, which I thought you'd want to know to make a note
of when committing this one.
So we decided in 8aba9322511f that it is okay to make the memory
context in which a transient partdesc is allocated a child of
PortalContext so that it disappears when the portal does. But
PortalContext is apparently NULL when the planner runs, at least in
the "simple" query protocol, so any transient partdescs built by the
planner would effectively leak. Not good.
With this patch, partdesc_nodetached is no longer transient, so the
problem doesn't exist.
I will write more about the updated patch in a bit...
--
Amit Langote
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2021-04-27 07:47:42 | Re: SQL-standard function body |
| Previous Message | Amit Kapila | 2021-04-27 07:25:01 | Re: [BUG] "FailedAssertion" reported when streaming in logical replication |