| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Cc: | Andrei Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>, Richard Guo <guofenglinux(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com> |
| Subject: | Re: Memory consumed by child SpecialJoinInfo in partitionwise join planning |
| Date: | 2024-03-25 09:16:50 |
| Message-ID: | CA+HiwqFDaKQsYqi_hc9bpM197tF5beNEdW+1Td9u-PoGn3J_ww@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 22, 2024 at 7:48 PM Ashutosh Bapat
<ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
> With the later code, semi_rhs_expr is indeed free'able. It wasn't so when I
> wrote the patches. Thanks for updating the comment. I wish we would have
> freeObject(). Nothing that can be done for this patch.
Yes.
> Attached patches
> Squashed your 0001 and 0002 into 0001. I have also reworded the commit message to reflect the latest code changes.
> 0002 has some minor edits. Please feel free to include or reject when committing the patch.
I've pushed this now.
When updating the commit message, I realized that you had made the
right call to divide the the changes around not translating the dummy
SpecialJoinInfos into a separate patch. So, I pushed it like that.
Thanks for working on this.
--
Thanks, Amit Langote
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2024-03-25 09:23:53 | Re: Introduce XID age and inactive timeout based replication slot invalidation |
| Previous Message | Hayato Kuroda (Fujitsu) | 2024-03-25 09:16:42 | RE: speed up a logical replica setup |