From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
---|---|
To: | jian he <jian(dot)universality(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pgsql: Add more SQL/JSON constructor functions |
Date: | 2024-07-26 02:12:27 |
Message-ID: | CA+HiwqEdRAyDru65yttp-MtgJ5m=VA0PfOKT4mytApARaGe5PA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Jul 25, 2024 at 11:16 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> On Wed, Jul 24, 2024 at 3:25 PM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
> > 2. domain over jsonb should fail just like domain over other types?
> > RETURNING djs keep quotes DEFAULT '"11"' ON empty
> > should fail as
> > ERROR: could not coerce ON EMPTY expression (DEFAULT) to the RETURNING type
> > DETAIL: value for domain djs violates check constraint "djs_check""
>
> I think this should be fixed with the attached patch 0004.
It is fixed but with the patch 0003, not 0004.
Also, the test cases in 0004, which is a patch to fix a problem with
OMIT QUOTES being disregarded when RETURNING domain-over-jsonb, didn't
test that problem. So I have updated the test case to use a domain
over jsonb.
--
Thanks, Amit Langote
Attachment | Content-Type | Size |
---|---|---|
0004-SQL-JSON-Respect-OMIT-QUOTES-when-RETURNING-domains-.patch | application/octet-stream | 4.9 KB |
0005-SQL-JSON-Remove-useless-code-in-ExecInitJsonExpr.patch | application/octet-stream | 1.6 KB |
0001-SQL-JSON-Some-fixes-to-JsonBehavior-expression-casti.patch | application/octet-stream | 15.9 KB |
0003-SQL-JSON-Fix-handling-of-errors-coercing-JsonBehavio.patch | application/octet-stream | 16.8 KB |
0002-SQL-JSON-Fix-casting-for-integer-EXISTS-columns-in-J.patch | application/octet-stream | 13.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Hayato Kuroda (Fujitsu) | 2024-07-26 02:31:39 | RE: [Proposal] Add foreign-server health checks infrastructure |
Previous Message | Erik Wienhold | 2024-07-26 02:11:22 | Re: CREATE TABLE creates a composite type corresponding to the table row, which is and is not there |