Re: pgsql: Add more SQL/JSON constructor functions

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: jian he <jian(dot)universality(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Add more SQL/JSON constructor functions
Date: 2024-07-26 08:53:32
Message-ID: CA+HiwqECD5RQZ6n8gK0mu_AeTJ5SbxzPgo20X-J5if_4ZEAhmg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 26, 2024 at 11:12 AM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> On Thu, Jul 25, 2024 at 11:16 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> > On Wed, Jul 24, 2024 at 3:25 PM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
> > > 2. domain over jsonb should fail just like domain over other types?
> > > RETURNING djs keep quotes DEFAULT '"11"' ON empty
> > > should fail as
> > > ERROR: could not coerce ON EMPTY expression (DEFAULT) to the RETURNING type
> > > DETAIL: value for domain djs violates check constraint "djs_check""
> >
> > I think this should be fixed with the attached patch 0004.
>
> It is fixed but with the patch 0003, not 0004.
>
> Also, the test cases in 0004, which is a patch to fix a problem with
> OMIT QUOTES being disregarded when RETURNING domain-over-jsonb, didn't
> test that problem. So I have updated the test case to use a domain
> over jsonb.

Pushed 0003-0005 ahead of 0001-0002. Will try to push them over the
weekend. Rebased for now.

--
Thanks, Amit Langote

Attachment Content-Type Size
0001-SQL-JSON-Some-fixes-to-JsonBehavior-expression-casti.patch application/octet-stream 16.6 KB
0002-SQL-JSON-Fix-casting-for-integer-EXISTS-columns-in-J.patch application/octet-stream 14.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2024-07-26 08:54:16 Re: Remove duplicate table scan in logical apply worker and code refactoring
Previous Message Alvaro Herrera 2024-07-26 08:36:08 Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails