| From: | Evan Jones <evan(dot)jones(at)datadoghq(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] pg_regress.c: Fix "make check" on Mac OS X: Pass DYLD_LIBRARY_PATH |
| Date: | 2023-06-06 14:24:45 |
| Message-ID: | CA+HWA9aGeSzLRuvAh8wksenpnu=q0HjXnNfNH2H8YByz5gps3g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 5, 2023 at 10:33 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Note that this is a known issue
> Yeah. We have attempted to work around this before, but failed to find
> a solution without more downsides than upsides. I will be interested
> to look at this patch, but lack time for it right now. Anybody else?
>
Ah, I didn't find that mention in the documentation when I was trying to
get this working. Sorry about that!
My argument in favour of considering this patch is that making
"./configure; make; make check" work on current major operating systems
makes it easier for others to contribute in the future. I think the
disadvantage of this patch is it makes pg_regress harder to understand,
because it requires an #ifdef for this OS specific behaviour, and obscures
the command lines of the child processes it spawns.
Thanks for considering it!
Evan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tristan Partin | 2023-06-06 14:24:56 | Potential us of initialized memory in xlogrecovery.c |
| Previous Message | Evan Jones | 2023-06-06 14:16:09 | Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific |