From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | Evan Jones <evan(dot)jones(at)datadoghq(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [PATCH] pg_regress.c: Fix "make check" on Mac OS X: Pass DYLD_LIBRARY_PATH |
Date: | 2023-06-06 21:23:50 |
Message-ID: | 2004d13a-6bd0-54c6-701b-f874a891dcb7@eisentraut.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 06.06.23 16:24, Evan Jones wrote:
> On Mon, Jun 5, 2023 at 10:33 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us
> <mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us>> wrote:
>
> > Note that this is a known issue
> Yeah. We have attempted to work around this before, but failed to find
> a solution without more downsides than upsides. I will be interested
> to look at this patch, but lack time for it right now. Anybody else?
>
>
> Ah, I didn't find that mention in the documentation when I was trying to
> get this working. Sorry about that!
>
> My argument in favour of considering this patch is that making
> "./configure; make; make check" work on current major operating systems
> makes it easier for others to contribute in the future. I think the
> disadvantage of this patch is it makes pg_regress harder to understand,
> because it requires an #ifdef for this OS specific behaviour, and
> obscures the command lines of the child processes it spawns.
This addresses only pg_regress. What about all the other test suites?
Per the previous discussions, you'd need to patch up other places in a
similar way, potentially everywhere system() is called.
From | Date | Subject | |
---|---|---|---|
Next Message | Evan Jones | 2023-06-06 21:43:57 | Re: [PATCH] pg_regress.c: Fix "make check" on Mac OS X: Pass DYLD_LIBRARY_PATH |
Previous Message | Peter Eisentraut | 2023-06-06 21:13:26 | Re: Improving FTS for Greek |