| From: | Jacob Brazeal <jacob(dot)brazeal(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Old BufferDesc refcount in PrintBufferDescs and PrintPinnedBufs |
| Date: | 2025-01-18 02:02:03 |
| Message-ID: | CA+COZaB1NcB3g+bSepXmkgWn0je5jYpq1Dtd+-WWki7fFyTipQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Since this patch takes out a lock to read the BufferDesc state, I also need
to release the lock, which I've added to this patch.
On Fri, Jan 17, 2025 at 2:11 PM Jacob Brazeal <jacob(dot)brazeal(at)gmail(dot)com>
wrote:
> Hi,
>
> In bufmgr.c we have the debugging functions PrintBufferDescs
> and PrintPinnedBufs, which are typically hidden behind the flag
> #ifdef NOT_USED. These functions reference the old buf->refcount and
> buf->flags fields, and so they no longer compile. I attached a patch to
> use BUF_STATE_GET_REFCOUNT instead and removed the reference to buf->flags.
>
> Regards,
> Jacob Brazeal
>
>
| Attachment | Content-Type | Size |
|---|---|---|
| v2-buf-helper-compile-err.patch | application/octet-stream | 2.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sergey Tatarintsev | 2025-01-18 03:08:43 | Re: create subscription with (origin = none, copy_data = on) |
| Previous Message | Tom Lane | 2025-01-18 01:43:32 | Re: rename es_epq_active to es_epqstate |