| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Junwang Zhao <zhjwpku(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Langote <amitlangote09(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: rename es_epq_active to es_epqstate |
| Date: | 2025-01-18 01:43:32 |
| Message-ID: | 2448639.1737164612@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Junwang Zhao <zhjwpku(at)gmail(dot)com> writes:
> ISTM Andres tend to use *es_epq_active* in a boolean way,
> like `if (es_epq_active) then`, but in the code base, all its usages
> follow pattern `if (es_epq_active == NULL) then`, so I propose to
> change es_epq_active to es_epqstate.
While I didn't especially love "es_epq_active" at the time,
I don't see that "es_epqstate" is much of an improvement:
it's an extremely generic name that conveys little information.
And renaming it now, years later, seems to add little except
back-patching hazards. So I'd vote for leaving it alone.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Brazeal | 2025-01-18 02:02:03 | Re: Old BufferDesc refcount in PrintBufferDescs and PrintPinnedBufs |
| Previous Message | Junwang Zhao | 2025-01-18 01:23:19 | rename es_epq_active to es_epqstate |