Re: Patch: Force Primitives

From: Nicholas White <n(dot)j(dot)white(at)gmail(dot)com>
To: pgsql-jdbc(at)postgresql(dot)org
Subject: Re: Patch: Force Primitives
Date: 2013-03-25 15:51:08
Message-ID: CA+=vxNZtH+coKeFC4X6wE3vay7FsJZRYu0ZGDpaxK6O-qz9MYg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc

I've revised the patch to make Array.getArray() return a primitive array
even when using the binary transfer format. I had to add extra code to
force a statement to do a describe query before executing (previously it
would only do this if the org.postgresql.forcebinary system property was
set), as the QueryExecutorImpl needs the Field objects to be populated when
sendBind is called, or the query results will be sent back in Text format.
The PrimitivesTest unit test my patch adds verifies that a column is being
returned in the correct (text or binary) format. I think this fixes an
outstanding bug; I believe binary transfers will only be used if the system
property is set, and the binaryTransfer JDBCUrl parameter is currently
useless.

Thanks -

Nick

Attachment Content-Type Size
force-primitives.patch application/octet-stream 16.7 KB

In response to

Responses

Browse pgsql-jdbc by date

  From Date Subject
Next Message Mikko Tiihonen 2013-03-25 17:24:25 Re: Patch: Force Primitives
Previous Message Nicholas White 2013-03-24 04:10:48 Patch: Force Primitives