Re: Patch: Force Primitives

From: Mikko Tiihonen <mikko(dot)tiihonen(at)nitorcreations(dot)com>
To: pgsql-jdbc(at)postgresql(dot)org
Subject: Re: Patch: Force Primitives
Date: 2013-03-25 17:24:25
Message-ID: 51508849.40007@nitorcreations.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc

On 03/25/2013 05:51 PM, Nicholas White wrote:
> I've revised the patch to make Array.getArray() return a primitive array even when using the binary transfer format. I had to add extra code to force a
> statement to do a describe query before executing (previously it would only do this if the org.postgresql.forcebinary system property was set), as the
> QueryExecutorImpl needs the Field objects to be populated when sendBind is called, or the query results will be sent back in Text format. The PrimitivesTest
> unit test my patch adds verifies that a column is being returned in the correct (text or binary) format. I think this fixes an outstanding bug; I believe binary
> transfers will only be used if the system property is set, and the binaryTransfer JDBCUrl parameter is currently useless.

By default the binary transfers for receive kick in only after the 3rd execution of a prepared statement. Do you see the binary transfers activating for array
receives if you run your prepared statement select in a loop?

The forceBinary option is for unit tests that do not want to repeat every statement 3 times.

-Mikko

In response to

Responses

Browse pgsql-jdbc by date

  From Date Subject
Next Message Nicholas White 2013-03-25 18:24:21 Re: Patch: Force Primitives
Previous Message Nicholas White 2013-03-25 15:51:08 Re: Patch: Force Primitives