From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | "Karl O(dot) Pinc" <kop(at)karlpinc(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Various small doc improvements; plpgsql, schemas, permissions, oidvector |
Date: | 2023-09-25 07:26:38 |
Message-ID: | C910C196-A1EF-4497-BC71-864A04E988BD@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 25 Sep 2023, at 00:57, Karl O. Pinc <kop(at)karlpinc(dot)com> wrote:
> I have made various, mostly unrelated to each other,
> small improvements to the documentation. These
> are usually in the areas of plpgsql, schemas, and permissions.
> Most change 1 lines, but some supply short overviews.
>
> "Short" is subjective, so if these need to be
> broken into different threads or different
> commitfest entries let me know.
While I agree it's subjective, I don't think adding a new section or paragraph
qualifies as short or small. I would prefer if each (related) change is in a
single commit with a commit message which describes the motivation for the
change. A reviewer can second-guess the rationale for the changes, but they
shouldn't have to.
The resulting patchset can all be in the same thread though.
--
Daniel Gustafsson
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2023-09-25 07:29:16 | Re: Confused about gram.y referencs in Makefile? |
Previous Message | torikoshia | 2023-09-25 07:21:31 | Re: RFC: Logging plan of the running query |