Re: lippq client library and openssl initialization: PQinitOpenSSL()

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Sebastien Flaesch <sebastien(dot)flaesch(at)4js(dot)com>, "pgsql-general(at)lists(dot)postgresql(dot)org" <pgsql-general(at)lists(dot)postgresql(dot)org>
Subject: Re: lippq client library and openssl initialization: PQinitOpenSSL()
Date: 2022-09-11 21:43:06
Message-ID: C3C3CD40-9F39-44DA-AFAA-AAD52002C3FA@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

> On 11 Sep 2022, at 23:35, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> On 11 Sep 2022, at 17:08, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Don't believe so. The HAVE_CRYPTO_LOCK stuff is all obsolete and
>>> not compiled if you built against 1.1.0. The only thing left that
>>> will happen if you don't call PQinitOpenSSL is an extra call to
>>> OPENSSL_init_ssl, which should be harmless as far as I can see
>>> from the OpenSSL docs.
>
>> To the best of my knowledge, thats entirely correct.
>
> Should we document these functions as obsolete when using
> OpenSSL >= 1.1.0 ?

Given that 1.1.0+ is very common, it's probably not a bad idea to document them
as obsolete but harmless. Unless you beat me to it I can propose a patch.

--
Daniel Gustafsson https://vmware.com/

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Peter Eisentraut 2022-09-12 11:21:57 Re: lippq client library and openssl initialization: PQinitOpenSSL()
Previous Message Tom Lane 2022-09-11 21:35:04 Re: lippq client library and openssl initialization: PQinitOpenSSL()