Re: lippq client library and openssl initialization: PQinitOpenSSL()

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Sebastien Flaesch <sebastien(dot)flaesch(at)4js(dot)com>, "pgsql-general(at)lists(dot)postgresql(dot)org" <pgsql-general(at)lists(dot)postgresql(dot)org>
Subject: Re: lippq client library and openssl initialization: PQinitOpenSSL()
Date: 2022-09-12 11:21:57
Message-ID: 6b1946ab-b6ff-8f0c-22d9-2456b04dd1b3@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

On 11.09.22 23:43, Daniel Gustafsson wrote:
>> On 11 Sep 2022, at 23:35, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>
>> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>>> On 11 Sep 2022, at 17:08, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>>> Don't believe so. The HAVE_CRYPTO_LOCK stuff is all obsolete and
>>>> not compiled if you built against 1.1.0. The only thing left that
>>>> will happen if you don't call PQinitOpenSSL is an extra call to
>>>> OPENSSL_init_ssl, which should be harmless as far as I can see
>>>> from the OpenSSL docs.
>>
>>> To the best of my knowledge, thats entirely correct.
>>
>> Should we document these functions as obsolete when using
>> OpenSSL >= 1.1.0 ?
>
> Given that 1.1.0+ is very common, it's probably not a bad idea to document them
> as obsolete but harmless. Unless you beat me to it I can propose a patch.

AFAICT, RHEL 7 ships with an older version. I think that's still pretty
widespread.

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Daniel Gustafsson 2022-09-12 11:55:29 Re: lippq client library and openssl initialization: PQinitOpenSSL()
Previous Message Daniel Gustafsson 2022-09-11 21:43:06 Re: lippq client library and openssl initialization: PQinitOpenSSL()