Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, bt23nguyent <bt23nguyent(at)oss(dot)nttdata(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set
Date: 2023-09-15 14:41:52
Message-ID: C2316C94-FE4C-4969-94DA-D7C4FDE3DA31@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 15 Sep 2023, at 16:38, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:

> this should use errdetail() instead of errhint(). In
> the provided patch, the new message explains how the module is not
> configured. It doesn't hint at how to fix it (although presumably one
> could figure that out pretty easily).

Fair point, I agree with your reasoning that errdetail seems more appropriate.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2023-09-15 14:42:10 Re: bug fix and documentation improvement about vacuumdb
Previous Message Nathan Bossart 2023-09-15 14:38:27 Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set