| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Kuwamura Masaki <kuwamura(at)db(dot)is(dot)i(dot)nagoya-u(dot)ac(dot)jp>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: bug fix and documentation improvement about vacuumdb |
| Date: | 2023-09-15 14:42:10 |
| Message-ID: | 20230915144210.GB1912920@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 15, 2023 at 10:13:10AM +0200, Daniel Gustafsson wrote:
>> On 15 Sep 2023, at 04:39, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote:
>> It seems to work fine. However, if we're aiming for consistent
>> spacing, the "IS NULL" (two spaces in between) might be an concern.
>
> I don't think that's a problem. I would rather have readable C code and two
> spaces in the generated SQL than contorting the C code to produce less
> whitespace in a query few will read in its generated form.
I think we could pretty easily avoid the extra space and keep the C code
relatively readable. These sorts of things bug me, too (see 2af3336).
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2023-09-15 14:54:30 | Re: Unlogged relations and WAL-logging |
| Previous Message | Daniel Gustafsson | 2023-09-15 14:41:52 | Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set |