Re: Libpq COPY optimization patch

From: "Alon Goldshuv" <agoldshuv(at)greenplum(dot)com>
To: pgsql-patches(at)postgresql(dot)org
Subject: Re: Libpq COPY optimization patch
Date: 2006-01-24 15:19:27
Message-ID: BFFC121F.C21E%agoldshuv@greenplum.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom,

>> Here is a patch against today's code 1/24. As discussed in -hackers
>> consumeInput/parse is removed from being called every single time. It's
>> still there for only when the data is sent to the server.
>
> This appears to be the exact same patch you sent before. Did you
> test my suggestion of simply removing the PQconsumeInput call?
> I see no reason to add it inside the loop.

My mistake. I'll make the correction.

I guess that although parseInput is cheap we could still use a conditional
to see when data was sent and only then call it (without PQconsumeInput)
instead of calling it every single time PQputCopyData is called. Any
objection to that?

Alon.

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-01-24 15:36:35 Re: Libpq COPY optimization patch
Previous Message Tom Lane 2006-01-24 15:11:07 Re: [HACKERS] CIDR/INET improvements