Re: Unfriendly handling of pg_hba SSL options with SSL off

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Unfriendly handling of pg_hba SSL options with SSL off
Date: 2011-05-30 18:26:00
Message-ID: BANLkTinO57O7V2RfXZ-ou5Hx-xS_DPJepw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 13, 2011 at 00:21, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> On Tue, May 10, 2011 at 05:39, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> I wouldn't have a problem with making the Windows port throw an error
>>> for "local" lines.  We'd have to fix initdb to remove that line from the
>>> sample file (if it doesn't already), but that's surely not hard.
>
>> It does already (that's what the @remove-line-for-nolocal@ markup in
>> the sample file is for).
>
>> So +1 for making it throw an error.
>
> Although this should be a simple change, I don't want to do it because
> I'm not in a position to test it.  Do you want to take care of it?

Here's a patch that I think does what we want. It works fine on
Windows - I just want to make sure this is what you meant as well?

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Attachment Content-Type Size
hba_nolocal.patch text/x-patch 1.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-05-30 18:39:37 Re: Unfriendly handling of pg_hba SSL options with SSL off
Previous Message Heikki Linnakangas 2011-05-30 17:47:44 Re: SSI predicate locking on heap -- tuple or row?