Re: pgsql: Remove the adminpack contrib extension

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Remove the adminpack contrib extension
Date: 2024-03-04 19:08:16
Message-ID: B5FC1FD8-01ED-4C22-BE98-8D483000E331@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

> On 4 Mar 2024, at 17:34, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> I see that my fix didn't solve it for 11 and 9.x on crake and drongo, will
>> rebuild more old trees and test to find the correct fix.
>
> The oldest branches didn't make that DB, so you need an "IF EXISTS".
> I pushed a fix after quickly checking it here.

Thanks for fixing, much appreciated!

The deviation between database names on crake found in the follow-up commit is
a bit concerning. Too much magic hidden away from the codetree makes it hard
to get tests right on the first try.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2024-03-04 19:42:00 pgsql: Fix pgindent damage.
Previous Message Robert Haas 2024-03-04 18:33:48 pgsql: Fix incremental backup interaction with XLOG_DBASE_CREATE_FILE_C