Re: plpython does not honour max-rows

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Kieran McCusker <kieran(dot)mccusker(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: plpython does not honour max-rows
Date: 2023-05-02 20:50:17
Message-ID: B5ECE886-8D9F-49D5-AC55-A3CC5353FBAC@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

> On 2 May 2023, at 22:39, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>>> On 2 May 2023, at 16:02, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> I wonder whether the similar plperl and pltcl wrappers are also
>>> documentation-shy here.
>
>> It seems like they are all a bit thin on explaining this. The attached diff
>> copies the wording (which unsurprisingly is pretty good IMO) into the
>> plperl/python/tcl documentation.
>
> Ah, seems like we set to work on this at the same time :-(

Pretty impressive timing across timezones =)

> I thought that s/max-rows/limit/ would be a good idea,

I was actually thinking about that but backed off to not confuse things with
LIMIT.

> mainly because
> plperl's spi_exec_prepared uses that name as a caller-exposed hash key.

But I didn't realize that, and in light of that I agree that limit is better.

> I'm not especially concerned about the wording otherwise.

Neither am I, both are fine I think.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2023-05-02 21:21:51 Re: plpython does not honour max-rows
Previous Message Tom Lane 2023-05-02 20:39:15 Re: plpython does not honour max-rows