| From: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: multiset patch review |
| Date: | 2011-01-13 01:40:49 |
| Message-ID: | AANLkTinw9=_Xdog2Q6-EECkBudXhM2fW+yTmbc=eSTbE@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 12, 2011 at 23:29, Alvaro Herrera
<alvherre(at)commandprompt(dot)com> wrote:
> Two small nitpicks:
> + check_concatinatable(Oid element_type1, Oid element_type2)
> + ereport(ERROR,
> + (errcode(ERRCODE_DATATYPE_MISMATCH),
> + errmsg("cannot concatenate incompatible arrays"),
> + errdetail("Arrays with element types %s and %s are not "
> + "compatible for concatenation.",
>
> I think the word is either "concatenable" or "concatenatable". Also
> please don't break up the string in errdetail() even if it's longer than
> 80 chars. (The function below this one has this too)
OK, I'll fix them,
but the broken up messages come from the existing code.
--
Itagaki Takahiro
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2011-01-13 01:45:23 | Re: Add support for logging the current role |
| Previous Message | Tom Lane | 2011-01-13 01:29:48 | Re: Add support for logging the current role |