Re: multiset patch review

From: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: multiset patch review
Date: 2011-01-18 08:39:37
Message-ID: AANLkTi=Z6hBnsTTq3Py_UqwpZP9uzAVL_Mo+OubODKBY@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 13, 2011 at 10:40, Itagaki Takahiro
<itagaki(dot)takahiro(at)gmail(dot)com> wrote:
>> I think the word is either "concatenable" or "concatenatable".  Also
>> please don't break up the string in errdetail() even if it's longer than
>> 80 chars.  (The function below this one has this too)
>
> OK, I'll fix them,
> but the broken up messages come from the existing code.

The attached is a fixed version.

BTW, should we use an "operator" to represent SUBMULTISET OF ?
It is mapped to submultiset_of "function" for now. If GIN and GiST
indexes will support the predicate in the future in addition to <@,
SUBMULTISET OF should be mapped to an operator rather than a function.
We need to choose different operator from <@ and @> for the case
because the semantics are not the same. (ex. <& and &>)

Note that MEMBER OF is represented as "ANY =".

--
Itagaki Takahiro

Attachment Content-Type Size
multiset-20110118.patch application/octet-stream 60.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2011-01-18 08:47:07 Re: limiting hint bit I/O
Previous Message Anssi Kääriäinen 2011-01-18 08:37:51 Re: REVIEW: Extensions support for pg_dump