Re: git diff script is not portable

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: git diff script is not portable
Date: 2010-11-17 19:03:28
Message-ID: AANLkTinmp26+sbe0rL4XF1N70bWR16g7hzTTcx-3seKs@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 17, 2010 at 19:54, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Looking here:
>
>        http://wiki.postgresql.org/wiki/Working_with_Git
>
> the script we recommend for doing context diffs for git,
> git-external-diff, is not portable:
>
>        http://anarazel.de/pg/git-external-diff
>
> It uses diff -L, which is not supported by FreeBSD, and I imagine many
> other operating systems.
>
> If we want people to use this to produce context diffs, we should
> provide a portable script.  I can modify it to be portable, but it is
> currently hosted on some other site.  How should I handle this?    How
> do I contact the author, or perhaps I should create a new on on
> ftp.postgresql.org and link to that.

Do it the git way - fork it and put it on your github page.

Or do it the pg way - fork it and put it in src/tools.

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-11-17 19:04:37 MergeAppend costing
Previous Message Bruce Momjian 2010-11-17 18:57:19 Re: Re: [BUGS] BUG #5650: Postgres service showing as stopped when in fact it is running