Re: git diff script is not portable

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: git diff script is not portable
Date: 2010-11-17 19:49:36
Message-ID: 201011171949.oAHJnag10452@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander wrote:
> On Wed, Nov 17, 2010 at 19:54, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > Looking here:
> >
> > ? ? ? ?http://wiki.postgresql.org/wiki/Working_with_Git
> >
> > the script we recommend for doing context diffs for git,
> > git-external-diff, is not portable:
> >
> > ? ? ? ?http://anarazel.de/pg/git-external-diff
> >
> > It uses diff -L, which is not supported by FreeBSD, and I imagine many
> > other operating systems.
> >
> > If we want people to use this to produce context diffs, we should
> > provide a portable script. ?I can modify it to be portable, but it is
> > currently hosted on some other site. ?How should I handle this? ? ?How
> > do I contact the author, or perhaps I should create a new on on
> > ftp.postgresql.org and link to that.
>
> Do it the git way - fork it and put it on your github page.
>
> Or do it the pg way - fork it and put it in src/tools.

src/tools is a very good idea. Objections?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2010-11-17 19:53:10 Re: unlogged tables
Previous Message Bruce Momjian 2010-11-17 19:47:48 Re: Re: [BUGS] BUG #5650: Postgres service showing as stopped when in fact it is running