| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | log_checkpoints and restartpoint |
| Date: | 2011-01-26 04:14:49 |
| Message-ID: | AANLkTinQmuuC1RDkPHt5Tsox+2u-DjL3zChhfWBf77Y1@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
When log_checkpoints is enabled, checkpoint logs the number of
WAL files created/deleted/recycled, but restartpoint doesn't.
This is OK before 9.0 because restartpoint had never created/
deleted/recycled WAL files. But, in 9.0 or later, restartpoint might
do that while walreceiver is running. So I think that it's useful to
log those numbers even in restartpoint in the now.
The attached patch changes LogCheckpointEnd so that it logs
the number of WAL files created/deleted/recycled even in
restartpoint.
And I found the problem about the initialization of CheckpointStats
struct. The attached patch also fixes this.
Comments?
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| log_restartpoint_v1.patch | application/octet-stream | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Itagaki Takahiro | 2011-01-26 04:53:10 | Re: REVIEW: WIP: plpgsql - foreach in |
| Previous Message | Steve Singer | 2011-01-26 03:51:42 | Re: pl/python SPI in subtransactions |