Re: log_checkpoints and restartpoint

On Tue, Jan 25, 2011 at 11:14 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> When log_checkpoints is enabled, checkpoint logs the number of
> WAL files created/deleted/recycled, but restartpoint doesn't.
> This is OK before 9.0 because restartpoint had never created/
> deleted/recycled WAL files. But, in 9.0 or later, restartpoint might
> do that while walreceiver is running. So I think that it's useful to
> log those numbers even in restartpoint in the now.
>
> The attached patch changes LogCheckpointEnd so that it logs
> the number of WAL files created/deleted/recycled even in
> restartpoint.
>
> And I found the problem about the initialization of CheckpointStats
> struct. The attached patch also fixes this.

This patch looks good to me. For now, I'm marking it Ready for
Committer. Absent objections, I will also commit it.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company