From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-bugs(at)postgresql(dot)org |
Subject: | Re: Invalid YAML output from EXPLAIN |
Date: | 2010-06-09 15:15:23 |
Message-ID: | AANLkTin4_TUrUaaF04RHVyOo_l5FwzbHfiiaq_shbPrc@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On 9 June 2010 16:05, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Jun 9, 2010 at 11:03 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>> On Wed, Jun 9, 2010 at 9:35 AM, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
>>>>> Does anyone care that Alias will sometimes be a string, and sometimes a number?
>>
>>> After further review, it appears to me that this change is pretty much
>>> required, because otherwise a string like 0xa won't be quoted. I
>>> might think it's OK for "123" to turn into 123, but I'm not going to
>>> be so happy about "0xa" turning into 10. Please test the attached
>>> patch.
>>
>> I still agree with Dean's original proposal: always quote the values of
>> strings.
>
> I'd still rather rip the format out entirely than do that. Dean's
> proposal was based on the idea that it would be safe to quote only the
> values and not the keys, which is not something I care to bank on.
>
Why? There are only a small number of keys, and we're completely in
control of them. You'd very quickly notice if one of them needed
quoting, which is not the case with values.
Dean
From | Date | Subject | |
---|---|---|---|
Next Message | Kevin Grittner | 2010-06-09 15:23:03 | Re: Invalid YAML output from EXPLAIN |
Previous Message | Tom Lane | 2010-06-09 15:14:14 | Re: Invalid YAML output from EXPLAIN |
From | Date | Subject | |
---|---|---|---|
Next Message | Kevin Grittner | 2010-06-09 15:23:03 | Re: Invalid YAML output from EXPLAIN |
Previous Message | Tom Lane | 2010-06-09 15:14:14 | Re: Invalid YAML output from EXPLAIN |