From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org |
Subject: | Re: Invalid YAML output from EXPLAIN |
Date: | 2010-06-09 15:05:03 |
Message-ID: | AANLkTikY4fYyGzm-qdWl7YvXUIyqu5gsVCdZGPzRfCI3@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On Wed, Jun 9, 2010 at 11:03 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Wed, Jun 9, 2010 at 9:35 AM, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
>>>> Does anyone care that Alias will sometimes be a string, and sometimes a number?
>
>> After further review, it appears to me that this change is pretty much
>> required, because otherwise a string like 0xa won't be quoted. I
>> might think it's OK for "123" to turn into 123, but I'm not going to
>> be so happy about "0xa" turning into 10. Please test the attached
>> patch.
>
> I still agree with Dean's original proposal: always quote the values of
> strings.
I'd still rather rip the format out entirely than do that. Dean's
proposal was based on the idea that it would be safe to quote only the
values and not the keys, which is not something I care to bank on.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-06-09 15:07:11 | Re: [BUGS] Server crash while trying to read expression using pg_get_expr() |
Previous Message | Tom Lane | 2010-06-09 15:03:17 | Re: Invalid YAML output from EXPLAIN |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-06-09 15:07:11 | Re: [BUGS] Server crash while trying to read expression using pg_get_expr() |
Previous Message | Tom Lane | 2010-06-09 15:03:17 | Re: Invalid YAML output from EXPLAIN |