| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Include WAL in base backup |
| Date: | 2011-01-24 07:45:25 |
| Message-ID: | AANLkTimpoudScpUgu58GvWLMCuZZYpwtAxDJz6ZCXepM@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 21, 2011 at 12:28 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>> - Why not initialize logid and logseg like so?:
>>>
>>> int logid = startptr.xlogid;
>>> int logseg = startptr.xrecoff / XLogSegSize;
>>>
>>> Then use those in your elog? Seems cleaner to me.
>
>> Hmm. Yes. Agreed.
>
> Marginal complaint here: int is the wrong type, I'm pretty sure.
And, we should use XLByteToPrevSeg here instead of just =, I think.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Itagaki Takahiro | 2011-01-24 07:45:49 | Re: multiset patch review |
| Previous Message | Heikki Linnakangas | 2011-01-24 07:29:14 | Re: SSI, simplified |