Re: Include WAL in base backup

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Include WAL in base backup
Date: 2011-01-20 15:28:25
Message-ID: 14124.1295537305@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> - Why not initialize logid and logseg like so?:
>>
>> int logid = startptr.xlogid;
>> int logseg = startptr.xrecoff / XLogSegSize;
>>
>> Then use those in your elog? Seems cleaner to me.

> Hmm. Yes. Agreed.

Marginal complaint here: int is the wrong type, I'm pretty sure.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Florian Pflug 2011-01-20 15:34:16 Re: pg_dump directory archive format / parallel pg_dump
Previous Message Tom Lane 2011-01-20 15:23:14 Re: Moving test_fsync to /contrib?