From: | Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | Re: pgAdmin III commit: Include a variant of sysSettings::Write() that take |
Date: | 2011-02-16 16:20:55 |
Message-ID: | AANLkTimikMhxmgJOrLfRhvNL21GoPeE2wvqZTyf4VLxH@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On 16 February 2011 15:47, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Include a variant of sysSettings::Write() that takes a wxChar* value
> to write, as they are currently being cast to bools and stored as
> true/false.
I anticipated this, and my latest patch doesn't have this problem -
it's the same situation as ctlListView, where we changed
AppendItem(const wxString&, bool) to AppendYesNoItem(const wxString&,
bool). I changed bool Write(const wxString&, bool) to bool
WriteBool(const wxString&, bool) in sysSettings's case.
I think that we perhaps overload too much in both of those classes.
The only reason that a call like this doesn't work with my code
presently:
sysSettings foo;
foo.Write(true);
is because we have an ambiguous conversion error (should it be a long
or an int?).
--
Regards,
Peter Geoghegan
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2011-02-16 18:34:16 | Re: phase 2 of wxWidgets 2.9 build |
Previous Message | Dave Page | 2011-02-16 15:48:16 | Re: pgAdmin III commit: Quick fix for a registry datatype issue on Windows, |