From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Timon <timosha(at)gmail(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: pgAdmin III commit: Quick fix for a registry datatype issue on Windows, |
Date: | 2011-02-16 15:48:16 |
Message-ID: | AANLkTi=FfRUyRNSEhoyOVb0pe5EC3ZObn0+UG29sS74A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks - I've committed a fix for this, that hopefully didn't break
anything else!
On Tue, Feb 15, 2011 at 10:40 AM, Timon <timosha(at)gmail(dot)com> wrote:
> This commit 8f9c483868c587cc2ac6332a927338426ae9836c broke an ability
> to suppress different guru hints.
>
> reproduce steps.
> 1. remove [Hints] from .pgadmin3
> 2. run pgadmin3
> 3. open connection to server
> 4. The windows "Guru Hint - Server instrumentation not installed" should appear
> 5. check "Do not show this hint again"
> 6. press ok button
> 7. close pgadmin3
> 8. run pgadmin3 again and connect to server
>
> On my system I see "Guru Hint - Server instrumentation not installed"
> window again, but I checked "Do not show this hint again" in step 4.
>
> before this commit in [Hints] section in .pgadmin3:
>
> [Hints]
> instrumentation=Suppress
>
> but after this commit
>
> [Hints]
> instrumentation=true
>
> 2011/2/1 Dave Page <dpage(at)pgadmin(dot)org>:
>> Quick fix for a registry datatype issue on Windows, introduced by
>> the wx 2.9 patch.
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=8f9c483868c587cc2ac6332a927338426ae9836c
>>
>> Modified Files
>> --------------
>> pgadmin/frm/frmHint.cpp | 2 +-
>> pgadmin/include/utils/sysSettings.h | 1 +
>> pgadmin/utils/sysSettings.cpp | 6 ++++++
>> 3 files changed, 8 insertions(+), 1 deletions(-)
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>
>
>
> --
> All bugs reserved
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2011-02-16 16:20:55 | Re: pgAdmin III commit: Include a variant of sysSettings::Write() that take |
Previous Message | Dave Page | 2011-02-16 15:47:35 | pgAdmin III commit: Include a variant of sysSettings::Write() that take |