Re: Caution when removing git branches

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Caution when removing git branches
Date: 2011-01-27 16:38:12
Message-ID: AANLkTikA6zu=7aUeW0TJobPqX_i=f5NZtzM26Abp_rJv@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 27, 2011 at 17:36, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>
> On 01/27/2011 11:29 AM, Tom Lane wrote:
>>
>> Given that nobody is supposed to push temporary branches to the master
>> repo anyway, an intended branch removal should be a pretty darn rare
>> event.  Now, our committers all seem to be pretty careful people, so
>> I don't feel strongly about having extra security on this --- but if
>> it's easy to do, it's probably a good idea.
>>
>
> Pushing a local topic branch by mistake seems much more likely to me. Some
> protection against that mightn't be a bad idea. Maybe for example a check on
> the branch name?

Or for that we could just disable branch creation *completely*, and
then turn off that restriction that one time / year that we actually
create a branch?

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2011-01-27 16:41:06 Re: Caution when removing git branches
Previous Message Robert Haas 2011-01-27 16:37:26 Re: ALTER TYPE 3: add facility to identify further no-work cases