From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Caution when removing git branches |
Date: | 2011-01-27 16:41:06 |
Message-ID: | 201101271641.p0RGf6W11794@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Magnus Hagander wrote:
> On Thu, Jan 27, 2011 at 17:36, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> >
> >
> > On 01/27/2011 11:29 AM, Tom Lane wrote:
> >>
> >> Given that nobody is supposed to push temporary branches to the master
> >> repo anyway, an intended branch removal should be a pretty darn rare
> >> event. ?Now, our committers all seem to be pretty careful people, so
> >> I don't feel strongly about having extra security on this --- but if
> >> it's easy to do, it's probably a good idea.
> >>
> >
> > Pushing a local topic branch by mistake seems much more likely to me. Some
> > protection against that mightn't be a bad idea. Maybe for example a check on
> > the branch name?
>
> Or for that we could just disable branch creation *completely*, and
> then turn off that restriction that one time / year that we actually
> create a branch?
Well, branch creation can always be undone --- branch removal seems like
the big problem because it can't.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2011-01-27 16:42:50 | Re: [HACKERS] reviewers needed! |
Previous Message | Magnus Hagander | 2011-01-27 16:38:12 | Re: Caution when removing git branches |